Add validations to the gateway apis to signal malformed proposal. #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional argument validatation and consistently use getters to safely traverse proto structures. Signed-off-by: andrew-coleman <[email protected]>
While new peer gateway service is trying to extract channel and chaincode information from the signed proposal it doesn't check the proposal fields for validity and therefore malformed proposal might end up with crashing peer service. This commit adds validation to the parameters extracted from the proposal. Signed-off-by: Artem Barger <[email protected]>
denyeart
approved these changes
Aug 8, 2022
|
@Mergifyio backport release-2.5 |
|
@Mergifyio backport release-2.4 |
✅ Backports have been created
|
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the new peer gateway service tries to extract channel and chaincode information from the signed proposal, it doesn't check the proposal fields for validity. Therefore malformed proposal might end up crashing peer service. This commit adds validation to the parameters extracted from the proposal.