Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector-corda): fix deploy-cordapp-jars-to-nodes-v4.8-express #3352

Conversation

petermetz
Copy link
Contributor

  1. Upgrading the images that were being used made it so that now the test
    is no longer flaky/broken (or at least that's what a series of executions
    of it made it looked like on my local machine)
  2. Based on the above it might be worthwhile to put this test back into the
    ones that are running (previously it was marked to be skipped).
  3. We should keep an eye on it to make sure it's not flaky on the CI either
    (which has resources much more constrained than my local development machine)

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. Upgrading the images that were being used made it so that now the test
is no longer flaky/broken (or at least that's what a series of executions
of it made it looked like on my local machine)
2. Based on the above it might be worthwhile to put this test back into the
ones that are running (previously it was marked to be skipped).
3. We should keep an eye on it to make sure it's not flaky on the CI either
(which has resources much more constrained than my local development machine)

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-connector-corda-fix-broken-test-case-deploy-cordapp-jars-to-nodes-v48-express branch from c87ecf4 to 74b373d Compare June 27, 2024 16:54
@petermetz petermetz merged commit ac6e884 into hyperledger-cacti:main Jun 27, 2024
146 of 150 checks passed
@petermetz petermetz deleted the test-connector-corda-fix-broken-test-case-deploy-cordapp-jars-to-nodes-v48-express branch June 27, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants