Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(yarn): update the lock file because it got out of sync 2023-nov-22 #2902

Merged

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Nov 22, 2023

Run of the mill lock file out of sync issue that happens every now and
then by mistake when we forget to run yarn install before committing our
changes for a PR.

Could've been avoided if we had the build-dev CI action set to
required but for now it gives us a better chance of reaching 2.0.0
if it's disabled temporarily.

[skip ci]

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Run of the mill lock file out of sync issue that happens every now and
then by mistake when we forget to run yarn install before committing our
changes for a PR.

Could've been avoided if we had the `build-dev` CI action set to
required but for now it gives us a better chance of reaching 2.0.0
if it's disabled temporarily.

[skip ci]

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the fix-yarn-lock-outdated-2023-nov-22 branch from 8c9a7d3 to e0bf51b Compare November 26, 2023 05:15
@petermetz petermetz merged commit e171d15 into hyperledger-cacti:main Nov 26, 2023
@petermetz petermetz deleted the fix-yarn-lock-outdated-2023-nov-22 branch November 26, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants