docs(examples/cbdc): fix mismatch of Fabric identities in GET and POST requests #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreAugusto11
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
changed the title
petermetz
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
@AndreAugusto11 I verified and it works. The caveat is still there that you have to manually refresh the page after having minted the tokens, but that's totally fine for a demo IMO.
FYI: I refactored the commit message and the PR title to not clutter the release notes showing this as a bug-fix in production code (it's an example so it won't make it to production)
LGTM
sandeepnRES
approved these changes
Oct 18, 2023
…equests The state keys were not being generated correctly for some reason It was working before without code changes so my best guess is that the Fabric ledger/SDK versions were changed and that's what tripped it up somehow. Fixes hyperledger-cacti#2739 [skip ci] Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: André Augusto <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES
force-pushed
the
fix-#2739
branch
from
e1b8034 to
57b57ce
Compare
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Nov 30, 2023
* What I believe has been an update to the Fabric SDK has lead the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping) * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint function was changed * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 * The crypto material is only used in the frontend for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For the critical operations, access control is being performed by the chaincode by using the call in the begining of the relevant methods Signed-off-by: André Augusto <[email protected]>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Nov 30, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping) * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint function was changed * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 * The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Nov 30, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping) * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint function was changed * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Signed-off-by: André Augusto <[email protected]>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Dec 2, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping). This was first noted in hyperledger-cacti#2739 * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint was changed, which caused other functions to be breaking at the moment (e.g., Escrow) This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 * The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Fixes hyperledger-cacti#2914
AndreAugusto11
pushed a commit
to AndreAugusto11/cacti
that referenced
this pull request
Dec 2, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping). This was first noted in hyperledger-cacti#2739 * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint was changed, which caused other functions to be breaking at the moment (e.g., Escrow) * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 * The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Fixes hyperledger-cacti#2914
AndreAugusto11
pushed a commit
to AndreAugusto11/cacti
that referenced
this pull request
Dec 2, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping). This was first noted in hyperledger-cacti#2739 * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint was changed, which caused other functions to be breaking at the moment (e.g., Escrow) * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 * The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Fixes hyperledger-cacti#2914 Signed-off-by: André Augusto <[email protected]>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Dec 2, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping). This was first noted in hyperledger-cacti#2739 * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint was changed, which caused other functions to be breaking at the moment (e.g., Escrow) * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 * The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Fixes hyperledger-cacti#2914 Signed-off-by: André Augusto <[email protected]>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Dec 2, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping) * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint function was changed * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Signed-off-by: André Augusto <[email protected]>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Dec 3, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping). This was first noted in hyperledger-cacti#2739 * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint was changed, which caused other functions to be breaking at the moment (e.g., Escrow) * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 * The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Fixes hyperledger-cacti#2914 Signed-off-by: André Augusto <[email protected]>
AndreAugusto11
added a commit
to AndreAugusto11/cacti
that referenced
this pull request
Dec 3, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping). This was first noted in hyperledger-cacti#2739 * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint was changed, which caused other functions to be breaking at the moment (e.g., Escrow) * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 * The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Fixes hyperledger-cacti#2914 Signed-off-by: André Augusto <[email protected]>
petermetz
pushed a commit
to AndreAugusto11/cacti
that referenced
this pull request
Dec 5, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping). This was first noted in hyperledger-cacti#2739 * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint was changed, which caused other functions to be breaking at the moment (e.g., Escrow) * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 * The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Fixes hyperledger-cacti#2914 Signed-off-by: André Augusto <[email protected]>
petermetz
pushed a commit
that referenced
this pull request
Dec 5, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping). This was first noted in #2739 * An initial fix was deployed in #2802 but only the Mint was changed, which caused other functions to be breaking at the moment (e.g., Escrow) * This commit changes the crypto material files and reverts the workaround in PR #2802 * The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Fixes #2914 Signed-off-by: André Augusto <[email protected]>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Dec 21, 2023
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping). This was first noted in hyperledger-cacti#2739 * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint was changed, which caused other functions to be breaking at the moment (e.g., Escrow) * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 * The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Fixes hyperledger-cacti#2914 Signed-off-by: André Augusto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(examples/cbdc): fix mismatch of Fabric identities in GET, POST requests
The state keys were not being generated correctly for some reason
It was working before without code changes so my best guess is that
the Fabric ledger/SDK versions were changed and that's what tripped it
up somehow.
Fixes #2739
[skip ci]
Co-authored-by: Peter Somogyvari [email protected]
Signed-off-by: André Augusto [email protected]
Signed-off-by: Peter Somogyvari [email protected]
cc: @petermetz @Anusha-Padmanabhan