This repository was archived by the owner on Mar 11, 2024. It is now read-only.
updates to core #222
Merged
updates to core #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
appetrosyan
reviewed
Feb 7, 2023
| @@ -0,0 +1 @@ | |||
| Cargo.lock | |||
There was a problem hiding this comment.
Shared objects are a murky area. I do think that given that Ursa is a primarily going to be used as an rlib, this is the right call.
ursa_core/src/lib.rs
Outdated
| @@ -1 +1,25 @@ | |||
| //! | |||
There was a problem hiding this comment.
Missing documentation. This will not be overridden. I suggest adding in a couple of lines or removing the doc marker entirely.
Signed-off-by: Michael Lodder <[email protected]>
mikelodder7
force-pushed
the
ml/core_updates
branch
from
42e39bf to
b761b0f
Compare
brentzundel
approved these changes
Feb 9, 2023
appetrosyan
approved these changes
Feb 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates define an error type that can be used across other packages that ursa makes available.