Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for RFC 9298 "Proxying UDP in HTTP" #203

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

dongcarl
Copy link
Contributor

  1. Add support for RFC 9298 in :protocol extension
  2. bugfix: Properly encode :protocol header
    Previously, the `:protocol` header wouldn't be set when the `Protocol`
    extension was active for a `Request`.
    
    This was most likely because the Webtransport PR (the PR that introduced
    the `Protocol` extension) did not include a client implementation and
    thus did not test this.
    

dongcarl added 2 commits July 10, 2023 22:01
Previously, the `:protocol` header wouldn't be set when the `Protocol`
extension was active for a `Request`.

This was most likely because the Webtransport PR (the PR that introduced
the `Protocol` extension) did not include a client implementation and
thus did not test this.
@dongcarl
Copy link
Contributor Author

@ten3roberts You might be interested in reviewing this 😬

@ten3roberts
Copy link
Contributor

Looks interesting, though I am unfortunately not a collaborator on this repository so I don't think I can submit a review.

But yes, you are indeed correct, the missing serialization of the protocol extension header is just an oversight as the Webtransport PR was only for the server due to PR size and usage requests.

Copy link
Contributor

@Ruben2424 Ruben2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you!

@ten3roberts We appreciate the value of feedback and reviews from everyone, whether you are a collaborator or not. You are welcome to submit a review if you would like to share your thoughts.

@Ruben2424 Ruben2424 merged commit 5a87580 into hyperium:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants