Skip to content

Commit

Permalink
Remove hanging reference to Remote Debugging endpoint on Android (fac…
Browse files Browse the repository at this point in the history
…ebook#48996)

Summary:

Follows react-native-community/discussions-and-proposals#872.

Changelog:
[Android][Removed] - Remove `DevSupportManagerFactory.launchJSDevtools` API

Differential Revision: D68766564
  • Loading branch information
huntie authored and facebook-github-bot committed Jan 28, 2025
1 parent 7016225 commit 5b97a34
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 27 deletions.
1 change: 0 additions & 1 deletion packages/react-native/ReactAndroid/api/ReactAndroid.api
Original file line number Diff line number Diff line change
Expand Up @@ -2095,7 +2095,6 @@ public class com/facebook/react/devsupport/DevServerHelper {
public fun getSourceUrl (Ljava/lang/String;)Ljava/lang/String;
public fun getWebsocketProxyURL ()Ljava/lang/String;
public fun isPackagerRunning (Lcom/facebook/react/devsupport/interfaces/PackagerStatusCallback;)V
public fun launchJSDevtools ()V
public fun openDebugger (Lcom/facebook/react/bridge/ReactContext;Ljava/lang/String;)V
public fun openInspectorConnection ()V
public fun openPackagerConnection (Ljava/lang/String;Lcom/facebook/react/devsupport/DevServerHelper$PackagerCommandListener;)V
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -426,32 +426,6 @@ public void isPackagerRunning(final PackagerStatusCallback callback) {
}
}

private String createLaunchJSDevtoolsCommandUrl() {
return String.format(
Locale.US,
"http://%s/launch-js-devtools",
mPackagerConnectionSettings.getDebugServerHost());
}

public void launchJSDevtools() {
Request request = new Request.Builder().url(createLaunchJSDevtoolsCommandUrl()).build();
mClient
.newCall(request)
.enqueue(
new Callback() {
@Override
public void onFailure(@NonNull Call call, @NonNull IOException e) {
// ignore HTTP call response, this is just to open a debugger page and there is no
// reason to report failures from here
}

@Override
public void onResponse(@NonNull Call call, @NonNull Response response) {
// ignore HTTP call response - see above
}
});
}

public String getSourceMapUrl(String mainModuleName) {
return createBundleURL(mainModuleName, BundleType.MAP);
}
Expand Down

0 comments on commit 5b97a34

Please sign in to comment.