Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isVisible is not an exported Prop of Pagination.Item #1681

Open
wizAIsoezuen opened this issue Feb 11, 2025 · 0 comments
Open

isVisible is not an exported Prop of Pagination.Item #1681

wizAIsoezuen opened this issue Feb 11, 2025 · 0 comments
Labels
contributions welcome Open to contributions docs A change or addition to the documentation

Comments

@wizAIsoezuen
Copy link

Describe the bug

Issue from #1077 still persists

Reproduction

Example from https://next.shadcn-svelte.com/docs/components/pagination

Logs

System Info

System:
    OS: macOS 15.3
    CPU: (8) arm64 Apple M3
    Memory: 71.08 MB / 24.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.13.1 - ~/.nvm/versions/node/v20.13.1/bin/node
    npm: 10.8.3 - ~/.nvm/versions/node/v20.13.1/bin/npm
  Browsers:
    Brave Browser: 132.1.74.50
    Chrome: 132.0.6834.160
    Safari: 18.3
  npmPackages:
    @sveltejs/kit: ^2.16.0 => 2.17.1 
    bits-ui: ^1.0.0-next.94 => 1.0.0-next.94 
    lucide-svelte: ^0.474.0 => 0.474.0 
    mode-watcher: ^0.5.1 => 0.5.1 
    svelte: ^5.0.0 => 5.19.9 
    svelte-sonner: ^0.3.28 => 0.3.28

Severity

annoyance

@huntabyte huntabyte added docs A change or addition to the documentation contributions welcome Open to contributions labels Feb 11, 2025
Zxce3 added a commit to Zxce3/shadcn-svelte that referenced this issue Mar 5, 2025
Related to huntabyte#1681

Update the Pagination component to use the `hidden` attribute instead of `isVisible`.

* Modify `sites/docs/src/content/components/pagination.md` to replace `isVisible` with `hidden` in the example code.
* Update `sites/docs/src/lib/registry/default/ui/pagination/pagination-item.svelte` to add the `hidden` attribute to the `li` element.
* Update `sites/docs/src/lib/registry/new-york/ui/pagination/pagination-item.svelte` to add the `hidden` attribute to the `li` element.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/huntabyte/shadcn-svelte/issues/1681?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome Open to contributions docs A change or addition to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants