is_safetensors_compatible fix #9741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Oct 22, 2024
Comment on lines
+200
to
+210
| def test_diffusers_is_compatible_no_components(self): | ||
| filenames = [ | ||
| "diffusion_pytorch_model.bin", | ||
| ] | ||
| self.assertFalse(is_safetensors_compatible(filenames)) | ||
|
|
||
| def test_diffusers_is_compatible_no_components_only_variants(self): | ||
| filenames = [ | ||
| "diffusion_pytorch_model.fp16.bin", | ||
| ] | ||
| self.assertFalse(is_safetensors_compatible(filenames)) |
There was a problem hiding this comment.
Would it also make sense to check the dummy repo here?
Comment on lines
+122
to
+123
| if not components: | ||
| return any(".safetensors" in filename for filename in filenames) |
There was a problem hiding this comment.
Would also mention the description of this function because this is not accounted for there.
| @@ -118,6 +118,10 @@ def is_safetensors_compatible(filenames, passed_components=None, folder_names=No | |||
| components.setdefault(component, []) | |||
| components[component].append(component_filename) | |||
|
|
|||
| # If there are no component folders check the main directory for safetensors files | |||
There was a problem hiding this comment.
Is this sufficient as a check? 👁️
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Caught during our release process. The following snippet fails
This is because:
https://huggingface.co/fusing/unet-ldm-dummy-update/tree/main
Doesn't have components in subfolders (which is what we usually expect for trying to load pipelines). The
is_safetensors_compatiblecheck was defaulting to True here because there were no components to iterate over.Changing so we have an additional check to handle this case by checking the main dir in the repo for safetensor files as well if there are no component folders.
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.