Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] refactoring docstrings in models/embeddings_flax.py #9592

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

Jwaminju
Copy link
Contributor

@Jwaminju Jwaminju commented Oct 5, 2024

What does this PR do?

Fixes part of #9567

Before submitting

Who can review?

This PR tries to attempt a solution at one of the submodules listed in #9567 so I think @a-r-r-o-w is the best to review it. Alongside the same, @charchit7 @yijun-lee and @SubhasmitaSw were also working on the same, so just a ping for the update on the same.

Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Could you look into the failing tests? I think you just have to run make style to fix

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Jwaminju Jwaminju force-pushed the args/embeddings_flax branch from a6b1cb5 to 0b56883 Compare October 8, 2024 13:08
@Jwaminju
Copy link
Contributor Author

Jwaminju commented Oct 8, 2024

Thanks for the review! I have removed trailing whitespace!

Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@a-r-r-o-w a-r-r-o-w merged commit a3e8d3f into huggingface:main Oct 15, 2024
15 checks passed
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* [docs] refactoring docstrings in `models/embeddings_flax.py`

* Update src/diffusers/models/embeddings_flax.py

* make style

---------

Co-authored-by: Aryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants