-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in Textual Inversion Unloading #9304
Conversation
hi @sayakpaul can you please chech the PR? it's really tiny |
Thanks! Could you also add / update tests for this? |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
@bonlime a gentle ping here. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@sayakpaul gentle ping worked :) |
@yiyixuxu could you give this a look?. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a single comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
can you |
Fixed style |
thanks for the PR! |
* Update textual_inversion.py * add unload test * add comment * fix style --------- Co-authored-by: Sayak Paul <[email protected]> Co-authored-by: Your Name <[email protected]> Co-authored-by: YiYi Xu <[email protected]>
What does this PR do?
Fixes Textual inversion unloading bug. To reproduce:
Would print:
Due to incorrect tokenizer size, after adding embedding 2nd time, it's not being correctly reset. After this PR the output would be correct:
Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).- [ ] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.- [ ] Did you make sure to update the documentation with your changes? Here are thedocumentation guidelines, and
here are tips on formatting docstrings.
- [ ] Did you write any new necessary tests?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.