-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-624 : Give executable permissions to all registry scripts #616
ISSUE-624 : Give executable permissions to all registry scripts #616
Conversation
Fixes #624 |
@suminb thanks for the PR. Can you set the same permissions to /conf/registry-env.sh as well ? |
Done. However, I found other
I would assume packages under |
@suminb Yeah, the docker scripts need the execute permissions. We don't need to set executable permissions for scripts run by npm. |
All done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM, thanks @suminb for the PR.
I've noticed the following scripts do not have executable permissions.
I would be nice to be able to run these files without manually giving executable permissions.