Investigate New Updates not properly batching

[zavreb]

Title: New Updates not properly batching and producing no new cards

QA TEMPLATE	Input
Device Type:	all
iOS:	11
tr Version:	1.65.0
Environment	prod (not sure about staging)
Codepush:	no
Internet Connection Type:	wifi
Users affected?	scurry, miranda, becky
User handle:	@scurry, becky
Bypass handle?:
Location access type?
Does this issue occur on other environments?	prod only, not sure about staging
Time issue occurred (UTC)	11:30 PM Tuesday, Coordinated Universal Time (UTC)

Observed Result:

When a user opens the app, and taps on New Updates, the notice the following:

1. Tapping on New Updates sometimes doesn't provide any new notifications, you simply tap on New Updates
2. Tapping on New Updates only give you some updates, but within a 10 second interval, the CTA keeps popping up and the user keeps having to tap on it in order to get new updates (mind you, this content had been created an hour beforehand, so it is not new content, I know this because the content that was pushing as a new update was user's @becky). Is this due to, improper batching? No queuing logic?

Expected Result:

1. Tapping on New Updates should provide a new card instead of providing the user with nothing.
2. User should only have to tap on New Updates once in order to receive all batched items vs. having to tap multiple times

Steps to reproduce:

1. Have users create multiple bots 30 minutes to an hour before you open your own account
2. Tap on New Updates
3. Experience the observed issues above

Related Screenshots/Video Links:

Question:

1. Has logic been implemented so that the user doesn't have to tap New Updates when they first open the app (instead the HS is updated) @thescurry, @bengtan this is probably a separate ticket but we need to consider how the HS should work when the user first opens the app or returns from background.

@mstidham to provide further commentary per her experience (below here):

[zavreb]

@aksonov, @bernardd can you please sync and explain in this ticket how new updates is handling new hs items? This will help QA's understanding and ticketing re: new updates functionality.

Per it's current functionality it seems (to QA) that:

• each item is being dealt with one at a time (not batching), this may be related to User taps New Updates and does not receive any new updates #1653

[southerneer]

I'm having trouble repro'ing on staging with my two accounts. Since the messages that represent new items come in one-at-a-time as a stream rather than in a batch it's entirely possible that users are getting messages just after hitting "New Updates". If that's the cause of the problem then we can build in a delay (a few seconds) before displaying "New Updates" to allow ample time for update messages to finish streaming in.

QA: One way to test this theory is to allow some time (call it 15 seconds) before pressing the New Update button.

We could also add a count beside New Updates. If this would be too busy or intrusive on prod then we could just do it in Staging for QA purposes.

[zavreb]

Messages? As in DMs or HS notifications? Will defer to the dev team as a whole for next steps.

Would prefer not adding the count. But could add the count for staging only to help us QA? cc: @thescurry

[aksonov]

@zavreb Unfortunately i was ooo when it was implemented. I will study the code today and try to fix that.

[aksonov]

Okey, I figured out that the current implementation is not correct - it uses 'live' subscriptions to get recent updates and the app doesn't know when all recent updates will be received (so various race conditions could occur when many updates are received). I talked with @bernardd and he prepared new API to get all updates from given timestamp.

[aksonov]

Server-side PR hippware/wocky#1190

[aksonov]

Please check my latest codepush

[mstidham]

Codepush verified Staging-Pavel "#1651"

[mstidham]

If this is a duplicate of #1653 then this will need rework. Staging Version 1.65.1

Experience 1. @TestAlly just created "ABC123 Lovebugz Child Care" @TestyTester had New Updates on HS. @TestyTester tapped New Updates and received the creation notification on HS. Immediately after @TestyTester had New Updates again, tapped New Updates and nothing changed on HS.

Experience 2: @TestAlly created bot "123456" and @TestyTester had app closed. @TestyTester opened app and tapped New Updates but did not receive the creation notification for "123456"

Update: This was tested without the Staging-Eric Codepush. Will now test with the codepush.

[mstidham]

Codepush Verified Staging Version 1.65.1 Codepush Staging-Eric "1645, 1646, 1651, and no broken homestream"

[aksonov]

Yes, looks like 1.65.1 is not latest master (why we published it at all?), but should be tested with codepush…

…

On 16 Dec 2017, at 14:26, mstidham ***@***.***> wrote: Codepush Verified Staging Version 1.65.1 Codepush Staging-Eric "1645, 1646, 1651, and no broken homestream" — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1651 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQpcfZ8QzfllgEE2VcBBeyxipPh0eIVks5tA8TsgaJpZM4Q_0XB>.

[aksonov]

Oh, I see probably it was published because of other issues. I moved it back to 'ready for deployment', sorry.

[mstidham]

Verified on Staging Version 1.65.2

[mstidham]

Verified on Prod Version 1.65.2

[zavreb]

I'd like to continue observing this once it's in the wild.

[thescurry]

I'm still seeing instances of this where the "New Updates" just continually re-appears.

[zavreb]

I'm thinking this batching issue is only happening when users change bot visibility pub --> priv...

Once we remove that issue we can start to diagnose if there's more of an issue left, otherwise I propose to ticket the above issue in another ticket and close this one.

[zavreb]

@thescurry, @bengtan fyi ^^^

[bengtan]

Purging due to redesign/board-restructure/out-of-date/etc.