Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cliprange for value fn (PPO2) #343

Merged
merged 3 commits into from
Jun 5, 2019
Merged

Add cliprange for value fn (PPO2) #343

merged 3 commits into from
Jun 5, 2019

Conversation

araffin
Copy link
Collaborator

@araffin araffin commented Jun 1, 2019

@araffin araffin requested review from AdamGleave, ernestum and hill-a June 1, 2019 10:31
@araffin araffin added this to the v2.6.0 milestone Jun 2, 2019
hill-a
hill-a approved these changes Jun 5, 2019
View reviewed changes
Copy link
Owner

@hill-a hill-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@hill-a hill-a merged commit fefff48 into master Jun 5, 2019
@araffin araffin deleted the ppo2-vf-clip branch June 5, 2019 09:10
@araffin araffin mentioned this pull request Jun 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hill-a hill-a hill-a approved these changes

@AdamGleave AdamGleave Awaiting requested review from AdamGleave

@ernestum ernestum Awaiting requested review from ernestum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.

PPO2 value function clipping seems to be flawed
2 participants
@araffin @hill-a