Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] filter_size can be a array instead of one value #317

Closed
yutingsz opened this issue May 9, 2019 · 3 comments · Fixed by #326
Closed

[feature request] filter_size can be a array instead of one value #317

yutingsz opened this issue May 9, 2019 · 3 comments · Fixed by #326
Labels
enhancement New feature or request

Comments

@yutingsz
Copy link

yutingsz commented May 9, 2019

My conv filter is not a square matrix. Its height is 1 and weight is 3.
In the conv function within the utils.py, the input parameter, filter_size, needs to be an array instead of a value. It is rather simple change.
@araffin araffin added the enhancement New feature or request label May 9, 2019
@araffin
Copy link
Collaborator

araffin commented May 10, 2019

Hello,
if it does not break anything, then yes, this should a good small improvement.

@yutingsz
Copy link
Author

Thanks. Do you want to update the code? Or I am happy to do my contribution to this project as I am using your code everyday.

@araffin
Copy link
Collaborator

araffin commented May 14, 2019

Or I am happy to do my contribution to this project as I am using your code everyday.

Yes, please do a PR and don't forget to read the contribution guide completely ;)

yutingsz pushed a commit to yutingsz/stable-baselines that referenced this issue May 15, 2019
Issue hill-a#317 [feature request] filter_size can be a array instead…
5f675aa 
… of one value
@yutingsz yutingsz mentioned this issue May 15, 2019
Merged
araffin pushed a commit that referenced this issue May 17, 2019
@yutingsz @araffin
[Feature] filter_size can be an array (#326)
fddf169 
* Issue #317 [feature request] filter_size can be a array instead of one value

* Issues #326 [Feature] filter_size can be a array

* Issue #326 [Feature] filter_size can be a array

* Issues #326 [Feature] filter_size can be a array: Line too long

* Update changelog.rst

* Issue #326 [Feature] filter_size can be a array, the added test code is test_a2c_conv.py

* Issues #326 [Feature] filter_size can be a array, remove the unused variables

* Issues #326 [Feature] filter_size can be a array, remove the unused library

* Issue #326, [Feature] filter_size can be a array. Clean up the test code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature] filter_size can be a array yutingsz/stable-baselines
2 participants
@araffin @yutingsz