bfg: add config option to disable public ws conns #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuasing
added
type: refactor
joshuasing
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom and
ClaytonNorthey92
ClaytonNorthey92
requested changes
Mar 10, 2025
There was a problem hiding this comment.
hey @joshuasing , could we add a test case for this? you can find an example that you could copy and paste from here https://github.com/hemilabs/heminetwork/pull/359/files#diff-f7bc76e889209de062a2c7c80346ee555bf7d7b24f5290830fac4a06cc87dcd5L4011
The PoP Miner uses errors.Is to check the authentication error, so testing this allows us to make sure the error will be handled correctly within the PoP Miner as well.
ClaytonNorthey92
approved these changes
Mar 10, 2025
AL-CT
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a configuration option
BFG_DISABLE_PUBLIC_CONNSto disable public WebSocket connections on BFG.When a PoP Miner connects and this option is enabled, the PoP Miner will be disconnected with an authentication error, which will result in the PoP Miner not retrying the connection.
Changes
BFG_DISABLE_PUBLIC_CONNSenvironment variable to BFG.protocol.ErrPublicKeyAutherror whenDisablePublicConnsistrue.