Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for image pull policy and secrets #92

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Add support for image pull policy and secrets #92

merged 2 commits into from
Oct 24, 2019

Conversation

jbialy
Copy link
Contributor

@jbialy jbialy commented Oct 21, 2019

This PR adds support for imagePullPolicy and imagePullSecrets.

Closes #84

Signed-off-by: Janusz Bialy [email protected]

Janusz Bialy added 2 commits October 21, 2019 16:34
add image pull policy and pull secrets
649acd2 
Signed-off-by: Janusz Bialy <[email protected]>
add unit tests
de1c693 
Signed-off-by: Janusz Bialy <[email protected]>
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 21, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jbialy jbialy changed the title Add pull policy and secrets Add support for image pull policy and secrets Oct 21, 2019
@iThuggin iThuggin mentioned this pull request Oct 22, 2019
Closed
@jbialy
Copy link
Contributor Author

jbialy commented Oct 24, 2019

Any chance of getting this PR reviewed and merged?

@jasonodonnell jasonodonnell self-requested a review October 24, 2019 16:41
jasonodonnell
jasonodonnell approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for the contribution!

@jasonodonnell jasonodonnell merged commit a2b2d32 into hashicorp:master Oct 24, 2019
radudd pushed a commit to radudd/vault-helm that referenced this pull request Jun 5, 2020
@jbialy @jasonodonnell
Add support for image pull policy and secrets (hashicorp#92)
a1b8a8f 
* add image pull policy and pull secrets

Signed-off-by: Janusz Bialy <[email protected]>

* add unit tests

Signed-off-by: Janusz Bialy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stateful Image Pull Policy
3 participants
@jbialy @hashicorp-cla @jasonodonnell