Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded service name in raft env #240

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Conversation

jasonodonnell
Copy link
Contributor

Small bug fix where the name of the cluster wasn't being prepended to the service name when deploying Raft clusters.

@jasonodonnell jasonodonnell requested a review from tvoran March 26, 2020 18:21
@jasonodonnell jasonodonnell changed the title Fix hardcoded service name in raft enfv Fix hardcoded service name in raft env Mar 26, 2020
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jasonodonnell jasonodonnell merged commit e97f4a5 into master Mar 26, 2020
@jasonodonnell jasonodonnell deleted the cluster-addr branch March 26, 2020 21:19
@danielmittelman
Copy link
Contributor

Nice! I was just going to open a PR for that, cool to see the active development of this chart 👍

radudd pushed a commit to radudd/vault-helm that referenced this pull request Jun 5, 2020
hadielaham88 pushed a commit to SolaceDev/vault-helm that referenced this pull request May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants