Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server-headless-service annotations #236

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Mar 20, 2020

Values.server.service.annotations are now being treated as multi-line
strings, to match the other annotations in the chart, and to support
templating within the annotations.

@jasonodonnell jasonodonnell self-requested a review March 20, 2020 17:49
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tvoran tvoran merged commit 0550623 into master Mar 20, 2020
@tvoran tvoran deleted the fix-headless-service branch March 20, 2020 17:54
radudd pushed a commit to radudd/vault-helm that referenced this pull request Jun 5, 2020
`Values.server.service.annotations` are now being treated as multi-line
strings, to match the other annotations in the chart, and to support
templating within the annotations.
hadielaham88 pushed a commit to SolaceDev/vault-helm that referenced this pull request May 19, 2021
`Values.server.service.annotations` are now being treated as multi-line
strings, to match the other annotations in the chart, and to support
templating within the annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants