Add preStop lifecycle hook #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radudd
pushed a commit
to radudd/vault-helm
that referenced
this pull request
Jun 5, 2020
* Add preStop lifecycle hook * Fix typo in comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes sends SIGTERM signals to pods being deleted and waits for a grace period before sending SIGKILL. The Vault pod wasn't receiving SIGTERM, so it never got the shutdown request, so the server was not shutting down gracefully. This resulted in slow failover, sluggish pod deletions and zombie Consul services.
Fixes #29