Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ephemeral storage of Agent sidecar injector configurable. #797

Closed
krishnadas-m opened this issue Oct 12, 2022 · 3 comments
Closed

Make ephemeral storage of Agent sidecar injector configurable. #797

krishnadas-m opened this issue Oct 12, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@krishnadas-m
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It is observed that the vault agent sidecar gets evicted due to the limit of ephemeral storage. It is currently defaulted to 128Mi and is not configurable via Helm-chart.

Describe the solution you'd like
If we can modify the injector-deployment template to template the AGENT_INJECT_EPHEMERAL_LIMIT value from values.yaml

Describe alternatives you've considered
We need to add/modify annotation on components to increase the limit which can be easily solved if we add the above mentioned capability on the vault helm-chart.

@krishnadas-m krishnadas-m added the enhancement New feature or request label Oct 12, 2022
krishnadas-m added a commit to krishnadas-m/vault-helm that referenced this issue Oct 12, 2022
@tvoran
Copy link
Member

tvoran commented Oct 12, 2022

Hi @krishnadas-m, this can be set via the helm chart currently with the injector.extraEnvironmentVars option.

The next release of vault-k8s will also stop setting a default ephemeral storage limit.

@krishnadas-m
Copy link
Contributor Author

Thanks for your reply

@krishnadas-m
Copy link
Contributor Author

will pass additional env variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants