Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statefulset Liveness Probe failing on standby nodes due to SSL, initial delay and 429 response #137

Closed
dclark opened this issue Dec 6, 2019 · 1 comment

Comments

@dclark
Copy link
Contributor

dclark commented Dec 6, 2019

  • Liveness probe failing when tls is enabled
  • Liveness and readiness probe on standby's receiving a 429 response rather than a 200
  • Liveness probe initialDelaySeconds is set to 5 seconds, value should be configurable and set to a higher default to allow for vault unsealing.
dclark added a commit to cwebd/vault-helm that referenced this issue Dec 6, 2019
…al delay and 429 response hashicorp#137

livenessProbe

 * Set the scheme to the vault.scheme to ensure that the check is works tls enabled or not.

 * Allow a configurable value initialDelaySeconds rather than the set 5 seconds.

 * Set the default initialDelaySeconds to 60 seconds before the probe starts to allow for vault unsealing.

 * Set the path to /v1/sys/health?standbyok=true to ensure a 200 response on standbys.

readinessProbe

 *  Set the path comment to /v1/sys/health?standbyok=true to ensure a 200 response on standbys.
dclark added a commit to cwebd/vault-helm that referenced this issue Dec 12, 2019
…al delay and 429 response hashicorp#137

livenessProbe

 * Set the scheme to the vault.scheme to ensure that the check is works tls enabled or not.

 * Allow a configurable value initialDelaySeconds rather than the set 5 seconds.

 * Set the default initialDelaySeconds to 60 seconds before the probe starts to allow for vault unsealing.

 * Set the path to /v1/sys/health?standbyok=true to ensure a 200 response on standbys.

readinessProbe

 *  Set the path comment to /v1/sys/health?standbyok=true to ensure a 200 response on standbys.

Statefulset liveness probe path check set to /v1/sys/health?standbyok=true
dclark added a commit to cwebd/vault-helm that referenced this issue Dec 12, 2019
…al delay and 429 response hashicorp#137

livenessProbe

 * Set the scheme to the vault.scheme to ensure that the check is works tls enabled or not.

 * Allow a configurable value initialDelaySeconds rather than the set 5 seconds.

 * Set the default initialDelaySeconds to 60 seconds before the probe starts to allow for vault unsealing.

 * Set the path to /v1/sys/health?standbyok=true to ensure a 200 response on standbys.

readinessProbe

 *  Set the path comment to /v1/sys/health?standbyok=true to ensure a 200 response on standbys.

Unit Tests

 * Statefulset liveness probe path check set to /v1/sys/health?standbyok=true
dclark added a commit to cwebd/vault-helm that referenced this issue Dec 12, 2019
…al delay and 429 response hashicorp#137

livenessProbe

 * Set the scheme to the vault.scheme to ensure that the check is works tls enabled or not.

 * Allow a configurable value initialDelaySeconds rather than the set 5 seconds.

 * Set the default initialDelaySeconds to 60 seconds before the probe starts to allow for vault unsealing.

 * Set the path to /v1/sys/health?standbyok=true to ensure a 200 response on standbys.

readinessProbe

 *  Set the path comment to /v1/sys/health?standbyok=true to ensure a 200 response on standbys.

Unit Tests

 * Statefulset liveness probe path check set to /v1/sys/health?standbyok=true

 * Server Statefulset test added for livenessProbe.initialDelaySeconds
dclark added a commit to cwebd/vault-helm that referenced this issue Dec 12, 2019
…al delay and 429 response hashicorp#137

livenessProbe

 * Set the scheme for vault.scheme to ensure that the check is works if tls enabled or not

 * Allow a configurable value initialDelaySeconds rather than the set 5 seconds

 * Set the default initialDelaySeconds to 60 seconds before the probe starts to allow for vault unsealing

 * Set the path to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

readinessProbe

 *  Set the path comment to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

Unit Tests

 * Statefulset liveness probe path check set to /v1/sys/health?standbyok=true

 * Server Statefulset test added for livenessProbe.initialDelaySeconds
dclark added a commit to cwebd/vault-helm that referenced this issue Dec 12, 2019
…al delay and 429 response hashicorp#137

livenessProbe

 * Set the scheme for vault.scheme to ensure that the check is works if tls enabled or not

 * Allow a configurable value initialDelaySeconds rather than the set 5 seconds

 * Set the default initialDelaySeconds to 60 seconds before the probe starts to allow for vault unsealing

 * Set the path to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

readinessProbe

 *  Set the path comment to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

Unit Tests

 * Statefulset liveness probe path check set to /v1/sys/health?standbyok=true

 * Server Statefulset test added for livenessProbe.initialDelaySeconds
dclark added a commit to cwebd/vault-helm that referenced this issue Dec 12, 2019
…al delay and 429 response hashicorp#137

livenessProbe

 * Set the scheme for vault.scheme to ensure that the check works if tls enabled or not

 * Allow a configurable value initialDelaySeconds rather than the set 5 seconds

 * Set the default initialDelaySeconds to 60 seconds before the probe starts to allow for vault unsealing

 * Set the path to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

readinessProbe

 *  Set the path comment to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

Unit Tests

 * Statefulset liveness probe path check set to /v1/sys/health?standbyok=true

 * Server Statefulset test added for livenessProbe.initialDelaySeconds
dclark added a commit to cwebd/vault-helm that referenced this issue Dec 12, 2019
…al delay and 429 response hashicorp#137

livenessProbe

 * Set the scheme for vault.scheme to ensure that the check works if tls enabled or not

 * Allow a configurable value initialDelaySeconds rather than the set 5 seconds

 * Set the default initialDelaySeconds to 60 seconds before the probe starts to allow for vault unsealing

 * Set the path to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

readinessProbe

 *  Set the path comment to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

Unit Tests

 * Statefulset liveness probe path check set to /v1/sys/health?standbyok=true

 * Server Statefulset test added for livenessProbe.initialDelaySeconds
dclark added a commit to cwebd/vault-helm that referenced this issue Dec 13, 2019
…al delay and 429 response hashicorp#137

livenessProbe

 * Set the scheme for vault.scheme to ensure that the check works if tls enabled or not

 * Allow a configurable value initialDelaySeconds rather than the set 5 seconds

 * Set the default initialDelaySeconds to 60 seconds before the probe starts to allow for vault unsealing

 * Set the path to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

readinessProbe

 * Set the path comment to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

 * Set the scheme for vault.scheme to ensure that the check works if tls enabled or not

 * Statefulset liveness probe path check set to /v1/sys/health?standbyok=true

 * Server Statefulset test added for livenessProbe.initialDelaySeconds
jasonodonnell pushed a commit that referenced this issue Dec 16, 2019
…al delay and 429 response #137 (#138)

livenessProbe

 * Set the scheme for vault.scheme to ensure that the check works if tls enabled or not

 * Allow a configurable value initialDelaySeconds rather than the set 5 seconds

 * Set the default initialDelaySeconds to 60 seconds before the probe starts to allow for vault unsealing

 * Set the path to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

readinessProbe

 * Set the path comment to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

 * Set the scheme for vault.scheme to ensure that the check works if tls enabled or not

 * Statefulset liveness probe path check set to /v1/sys/health?standbyok=true

 * Server Statefulset test added for livenessProbe.initialDelaySeconds
@jasonodonnell
Copy link
Contributor

Merged, closing.

radudd pushed a commit to radudd/vault-helm that referenced this issue Jun 5, 2020
…al delay and 429 response hashicorp#137 (hashicorp#138)

livenessProbe

 * Set the scheme for vault.scheme to ensure that the check works if tls enabled or not

 * Allow a configurable value initialDelaySeconds rather than the set 5 seconds

 * Set the default initialDelaySeconds to 60 seconds before the probe starts to allow for vault unsealing

 * Set the path to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

readinessProbe

 * Set the path comment to /v1/sys/health?standbyok=true to ensure a 200 response on standbys

 * Set the scheme for vault.scheme to ensure that the check works if tls enabled or not

 * Statefulset liveness probe path check set to /v1/sys/health?standbyok=true

 * Server Statefulset test added for livenessProbe.initialDelaySeconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants