Backport of cli: Optimize for large multi-line string outputs into v0.14 #27747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #27746 to be assessed for backporting due to the inclusion of the label 0.14-backport.
The below text is copied from the body of the original PR.
When rendering a new, very large multi-line string output as part of
terraform plan
orterraform apply
, we hit this code path:terraform/command/format/diff.go
Lines 699 to 711 in 14936e6
The
writeValueDiff
multi-line string renderer calculates a longest common subsequence, which is an operation with quadratic time and space complexity. When the "two" strings are in fact the same value (as you can see from the call above), this results in a worst-case execution time. For very large strings, this can be several minutes:This commit adds an early shortcut for this specific case, using simple string equality as the test, which directly prints the multi-line string without calculating an LCS. This dramatically improves the runtime in this specific edge case:
Fixes #27743