add support for includes function

[njuCZ]

fix #27198

[codecov]

Codecov Report

Merging #27518 (0caf5ed) into master (bd6b973) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files	Coverage Δ
lang/funcs/string.go	100.00% <100.00%> (ø)
lang/functions.go	96.29% <100.00%> (+0.02%)	⬆️
dag/marshal.go	61.90% <0.00%> (-1.59%)	⬇️

[jgrumboe]

@njuCZ
Wouldn't "includes" be a better functionname in analogy to "contains"?
"Include" sounds more imperative than "includes" which sounds like a question, which the function actually is.

[njuCZ]

@jgrumboe Thanks for the suggestions. I will changed to includes soon

[njuCZ]

@jgrumboe I have refactor it to includes.

[orgads]

Is anything blocking this PR from being merged, except rebase?

[hashicorp-cla]

All committers have signed the CLA.

[Cliftonz]

@njuCZ Is anything blocking this PR?

[crw]

@Cliftonz I am checking in with the team. Will put this back on the queue for triage. If the core team gives the thumbs-up, then @njuCZ would need to rebase (and fix any potential feedback) before it could be merged. Thanks!

[Cliftonz]

@crw Thank you! If @njuCZ is unavailable I am happy to take this over.

[kmoe]

Happy to merge this if the name of the function is changed to strcontains, to match our naming conventions.

[Cliftonz]

@kmoe Is there any issue if I make a new pull request as OP is not responding?

[digital-content-events]

📄 Content Checks

Updated: Fri, 21 Apr 2023 06:10:49 GMT

Found 1 error(s)

docs/language/functions/strcontains.mdx

Position	Description	Rule
1:1-1:1	This file is not present in the nav data file at data/language-nav-data.json. Either add a path that maps to this file in the nav data or remove the file. If you want the page to exist but not be linked in the navigation, add a hidden property to the associated nav node.	no-unlinked-pages

[njuCZ]

@Cliftonz thanks if you can take over this PR. (It seems the CI needs to deploy a github app and I can't do that for current account). I will close it for now.

[Cliftonz]

@njuCZ No problem, thank you for getting this going!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.