Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of backend/remote: No version check for operations into v0.14 #27400

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #27319 to be assessed for backporting due to the inclusion of the label 0.14-backport.

The below text is copied from the body of the original PR.


Terraform remote version conflicts are not a concern for operations. We are in one of three states:

  • Running remotely, in which case the local version is irrelevant;
  • Workspace configured for local operations, in which case the remote version is meaningless;
  • Forcing local operations with a remote backend, which should only happen in the Terraform Cloud worker, in which case the Terraform versions by definition match.

This commit therefore disables the version check for operations (plan and apply), which has the consequence of disabling it in Terraform Cloud and Enterprise runs. In turn this enables Terraform Enterprise runs with bundles which have a version that doesn't exactly match the bundled Terraform version.

Intended for back-port to 0.14 for an upcoming release.

@teamterraform teamterraform force-pushed the backport/alisdair/backend-remote-no-version-check-for-operations/heavily-relaxing-hawk branch from cece601 to e405862 Compare January 4, 2021 18:53
@teamterraform teamterraform requested a review from alisdair January 4, 2021 18:53
@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #27400 (e9429ac) into v0.14 (5389db2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
backend/remote/backend.go 62.67% <100.00%> (-0.15%) ⬇️
terraform/evaluate.go 53.30% <0.00%> (+0.41%) ⬆️
dag/marshal.go 54.79% <0.00%> (+1.36%) ⬆️
terraform/node_resource_plan.go 97.19% <0.00%> (+1.86%) ⬆️

@alisdair alisdair force-pushed the backport/alisdair/backend-remote-no-version-check-for-operations/heavily-relaxing-hawk branch from e405862 to 56f4a46 Compare January 4, 2021 20:23
@alisdair alisdair merged commit ec0d16b into v0.14 Jan 4, 2021
@alisdair alisdair deleted the backport/alisdair/backend-remote-no-version-check-for-operations/heavily-relaxing-hawk branch January 4, 2021 20:34
@ghost
Copy link

ghost commented Feb 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants