Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Update docs and add warning for -get-plugins into v0.14 #27176

Merged

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #27169 to be assessed for backporting due to the inclusion of the label 0.14-backport.

The below text is copied from the body of the original PR.


As of Terraform 0.13+, the get-plugins command has been superseded by new provider installation mechanisms, and general philosophy (providers are always installed, but the sources may be customized). Update the init command to give users a warning if they are setting this flag, to encourage them to remove it from their workflow, and update relevant docs and docstrings as well.

Fixes #27092

Looking to backport to 0.14 (which would give 0.14.1+ users a warning when using this flag), and remove the flag completely in 0.15 after this.

Also looking for:

  • Are the reccs here the preferred recommendations for people using this flag?
  • Approval/Nay-saying on the "add a warning, then remove completely" plan
  • Should this be backported to 0.13 as well?

@teamterraform teamterraform force-pushed the backport/pselle/get-plugins/accurately-harmless-hyena branch from b102787 to 304f96d Compare December 7, 2020 19:22
@teamterraform teamterraform requested a review from pselle December 7, 2020 19:22
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #27176 (304f96d) into v0.14 (a013a3a) will decrease coverage by 0.00%.
The diff coverage is 53.84%.

Impacted Files Coverage Δ
command/init.go 62.33% <53.84%> (-0.39%) ⬇️
dag/marshal.go 53.42% <0.00%> (-1.37%) ⬇️

@pselle pselle self-assigned this Dec 7, 2020
@pselle pselle merged commit 9bb523a into v0.14 Dec 8, 2020
@pselle pselle deleted the backport/pselle/get-plugins/accurately-harmless-hyena branch December 8, 2020 22:00
@ghost
Copy link

ghost commented Jan 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants