Fix terraform force-unlock <lock_id> for Consul backend
#25837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When locking was enabled with the Consul backend and the lock not properly released, the `terraform force-unlock <lock_id>` command would do nothing as its implementation would exit early in that case. It now destroys the session that created the lock and clean both the lock and the lock-info keys. A regression test is added to TestConsul_destroyLock() to catch the issue if it happends again. Closes hashicorp#22174
This was referenced Aug 13, 2020
Codecov Report
|
|
@remilapeyre Thank you for this fix! Unfortunately there's a conflict after merging #25842. Would you mind rebasing? |
|
Hi @alisdair, sorry I had missed your message, it should all be good now :) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When locking was enabled with the Consul backend and the lock not properly
released, the
terraform force-unlock <lock_id>command would do nothing asits implementation would exit early in that case.
It now destroys the session that created the lock and clean both the lock and
the lock-info keys.
A regression test is added to TestConsul_destroyLock() to catch the issue if it
happends again.
Closes #22174