Skip to content

Commit

Permalink
require all identity attributes to be specified
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielMSchmidt authored and dbanck committed Feb 17, 2025
1 parent 9f2273b commit 7d4baaf
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion internal/configs/configschema/decoder_spec.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,12 @@ func (a *IdentityAttribute) decoderSpec(name string) hcldec.Spec {

ret := &hcldec.AttrSpec{Name: name}
ret.Type = a.Type
ret.Required = a.RequiredForImport // TODO? check
// When dealing with IdentityAttribute we expect every attribute to be required.
// This is generally true for all communication between providers and Terraform.
// For import, we allow the user to only specify a subset of the attributes, where
// RequiredForImport attributes are required and OptionalForImport attributes are optional.
// The validation for this will rely on a separate spec.
ret.Required = true

return ret
}
Expand Down

0 comments on commit 7d4baaf

Please sign in to comment.