lookup(): only treat map as unknown if it is wholly unknown

Fix for issue #26320 - this allows us to derive known values from partially known maps where we can, and may prevent unnecessary destroy/rebuild cycles during apply in some cases.
hashicorp · Oct 2, 2020 · 28cb0ab · 28cb0ab
1 parent a78d75c
commit 28cb0ab
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lang/funcs/collection.go b/lang/funcs/collection.go
@@ -315,7 +315,7 @@ var LookupFunc = function.New(&function.Spec{
 		mapVar := args[0]
 		lookupKey := args[1].AsString()
 
-		if !mapVar.IsWhollyKnown() {
+		if !mapVar.IsKnown() {
 			return cty.UnknownVal(retType), nil
 		}
 

diff --git a/lang/funcs/collection_test.go b/lang/funcs/collection_test.go
@@ -720,6 +720,14 @@ func TestLookup(t *testing.T) {
 			cty.UnknownVal(cty.String),
 			false,
 		},
+		{
+			[]cty.Value{
+				mapWithUnknowns,
+				cty.StringVal("foo"),
+			},
+			cty.StringVal("bar"),
+			false,
+		},
 		{
 			[]cty.Value{
 				simpleMap,