Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_template_deployment - Support import #8497

Conversation

ArcturusZhang
Copy link
Contributor

Fixes #7268

@tombuildsstuff
Copy link
Contributor

hi @ArcturusZhang

Thanks for this PR.

Taking a look through here, whilst this PR does add support for import to this resource - since the template content isn't being returned from the Azure API here, unfortunately this'd lead to a diff here (null -> 'template body').

Whilst we could look to set this field into the state to allow us to track this - after spending some time with this (and #7506) it likely makes more sense to overhaul these resources to support the updated behaviours now present in this API.

In particular, since the API now returns a list of resources provisioned by this ARM Template - we're able to attempt to clean these up during deletion of the ARM Template Deployment (which can be toggled on/off using the features block).

As we're looking to take a different direction here - whilst I'd like to thank you for this contribution I'm going to close this in favour of #8672 which introduces a replacement for this resource, and the existing azurerm_template_deployment resource will be deprecated in version 3.0 of the Azure Provider.

Thanks!

@ArcturusZhang ArcturusZhang deleted the template-deployment-support-import branch September 29, 2020 08:36
@ghost
Copy link

ghost commented Oct 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_template_deployment doesn't support import
2 participants