Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update key vault key and secret id when reading #7841

Closed
wants to merge 1 commit into from

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jul 22, 2020

fix #6222

the reason of this issue is:

  1. user create a new version secret via the portal
  2. terraform plan will read the latest secret version and find tags is missing
  3. terraform update will only update the tags of id.version.

Because id is not updated, so it's not updating the latest version. The next Time terraform plan it will show diff again.

I think key vault key also have such problem

@tombuildsstuff
Copy link
Contributor

hey @njuCZ

Thanks for this PR.

Updating the ID of a resource during a Read isn't a recommended practice (since this can cause graph changes, which requires multiple Terraform runs) - as such I've taken a look into this and it appears that instead we can update the latest version rather than this version specifically, always pulling the version out during the update - which should achieve the same thing here.

As such whilst I'd like to thank you for opening this PR I'm going to close this in favour of #8304 which solves this problem in a slightly different way.

Thanks!

@ghost
Copy link

ghost commented Oct 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The provider does not update Key Vault Secret tags when there are only tag changes/content type
2 participants