-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Network Rule Set to Servicebus Namespace #5533
Add Network Rule Set to Servicebus Namespace #5533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @guillaumestevens
Thanks for this PR.
This should be a new resource (azurerm_servicebus_namespace_network_rule_set
), rather than extending the namespace resource. The Create/Update lifecycle of a azurerm_servicebus_namespace
doesn't include the network_ruleset, but has its own Create/Update functions as a separate entity. (Similar to azurerm_servicebus_namespace_authorization_rule
). Could you split your work out into the new resource so we can help you progress this?
Thanks,
Ste
ok i'll do the split. Guillaume |
…ther than extending the namespace resource)
i've just pushed the change. Guillaume |
Hey @guillaumestevens, Sorry we have taken so long to get back to this. It seems there is a more complete & up to date pr at #6379 without conflict. As such i'm going to close this and i thank you again for opening the PR! |
This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.7.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Add a network rule set block to define network restrictions (ip & vnet). Based on Network rule set already present in eventhub_namespace resource.
tests are updated, however, when i'm running them on my laptop, he crash (CPU overload).