-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring the Examples folder #3046
Merged
Merged
+3,247
−6,449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This historically was a VM, but this is now unnecessary
appilon
approved these changes
Mar 13, 2019
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Examples folder in several ways:
prefix
andlocation
; althoughalt_location
,kubernetes_client_id
andkubernetes_client_secret
are also used).skip-test
file, which means these won't be tested)Given this is refactoring the folder fairly substantially, I'd suggest it'd probably easiest to view the result in the examples folder in the GitHub UI: https://github.com/terraform-providers/terraform-provider-azurerm/tree/f/examples/examples
It's also possible to run the Acceptance Test for the Examples like so (although getting each example passing is a separate job):
$ TF_EXAMPLE_TEST=1 ARM_TENANT_ID=00000000-0000-0000-0000-000000000000 ARM_SUBSCRIPTION_ID=00000000-0000-0000-0000-000000000000 ARM_ENVIRONMENT=public ARM_LOCATION=westeurope ARM_CLIENT_ID=00000000-0000-0000-0000-000000000000 ARM_CLIENT_SECRET=00000000-0000-0000-0000-000000000000 go test -v ./examples/