-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_netapp_volume - support the data_protection_replication
block
#10610
azurerm_netapp_volume - support the data_protection_replication
block
#10610
Conversation
…more and it is ignored if passed and a warn is generated
…one from the backend on primary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @paulomarquesc - overall this looks good, but i've left a couple comments inline that once addressed this should be good to merge 🚀
azurerm/internal/services/netapp/netapp_volume_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/netapp/netapp_volume_resource_test.go
Outdated
Show resolved
Hide resolved
Hi @katbyte , just pushed new commit to fix your comments and CI linting issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paulomarquesc - i've left some more comments inline
Co-authored-by: kt <[email protected]>
Co-authored-by: kt <[email protected]>
Co-authored-by: kt <[email protected]>
This reverts commit deb1f5c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paulomarquesc - aside from a few minor comments this LGTM now ! 👍
Thanks Katie. |
data_protection_replication
block
This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.49.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR implements support for Cross-Region Replication (CRR) feature of ANF Volumes.
Worth it to call out that since CRR is extremely sensitive on resources being complete, we extended usage of stateCOnf.WaitForState for all steps of volume creation/deletion.