New resource: azurerm_express_route_port

[magodo]

New resource: azurerm_express_route_port

Reference

• https://docs.microsoft.com/en-us/azure/expressroute/expressroute-erdirect-about

Test Result

💤 make testacc TEST=./azurerm/internal/services/network/tests TESTARGS='-run=TestAccAzureRMExpressRoutePort_'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/network/tests -v -run=TestAccAzureRMExpressRoutePort_ -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMExpressRoutePort_basic
=== PAUSE TestAccAzureRMExpressRoutePort_basic
=== RUN   TestAccAzureRMExpressRoutePort_complete
=== PAUSE TestAccAzureRMExpressRoutePort_complete
=== RUN   TestAccAzureRMExpressRoutePort_update
=== PAUSE TestAccAzureRMExpressRoutePort_update
=== RUN   TestAccAzureRMExpressRoutePort_requiresImport
=== PAUSE TestAccAzureRMExpressRoutePort_requiresImport
=== RUN   TestAccAzureRMExpressRoutePort_userAssignedIdentity
=== PAUSE TestAccAzureRMExpressRoutePort_userAssignedIdentity
=== CONT  TestAccAzureRMExpressRoutePort_basic
=== CONT  TestAccAzureRMExpressRoutePort_requiresImport
=== CONT  TestAccAzureRMExpressRoutePort_update
=== CONT  TestAccAzureRMExpressRoutePort_complete
=== CONT  TestAccAzureRMExpressRoutePort_userAssignedIdentity
--- PASS: TestAccAzureRMExpressRoutePort_basic (166.46s)
--- PASS: TestAccAzureRMExpressRoutePort_requiresImport (177.45s)
--- PASS: TestAccAzureRMExpressRoutePort_userAssignedIdentity (189.52s)
--- PASS: TestAccAzureRMExpressRoutePort_complete (227.78s)
--- PASS: TestAccAzureRMExpressRoutePort_update (289.52s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests       289.569s

Cost

This resource takes a high cost on creation. Please refer to its pricing page for details.

[katbyte]

Aside from a few minor comments about schema this looks good @magodo

[magodo]

@katbyte Thank you for the review comments! I've resolved some of them and leaving the others for your further inputs. Please take another look :)

[katbyte]

Thanks @magodo aside from one comment this LGTM 👍

[ghost]

This has been released in version 2.55.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.55.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!