Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"azurerm_storage_share_directory" fails to create folder with two hyphens in name #8341

Closed
mrmatimba opened this issue Sep 3, 2020 · 4 comments · Fixed by #8366
Closed

Comments

@mrmatimba
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.13
AzureRM 2.25.0

Affected Resource(s)

  • azurerm_storage_share_directory

Terraform Configuration Files

resource "azurerm_storage_share_directory" "folder01" {

  name                 = "test-folder-1"
  share_name           = var.share_name
  storage_account_name = var.storage_account_name
}

Expected Behavior

Folder "test-folder-1" is created

Actual Behavior

Error output:

Error: name must contain only uppercase and lowercase alphanumeric characters, numbers and hyphens. It must start and end with a letter and end only with a number or letter and can only be nested one level
on code/iac/sftp/main.tf line 57, in resource "azurerm_storage_share_directory" "folder01":
57: resource "azurerm_storage_share_directory" "folder01" {

Steps to Reproduce

  1. terraform apply

References

Probably caused due to new regex pattern from #7382 for validating folder names

@neil-yechenwei
Copy link
Contributor

Thanks for opening this issue. Hopes this fix would be helpful.

@mrmatimba
Copy link
Author

mrmatimba commented Sep 7, 2020

Hi @neil-yechenwei ,

Looks totally fine. Thanks for the quick help! Will this fix be part of v2.27?

@WodansSon WodansSon added this to the v2.27.0 milestone Sep 8, 2020
WodansSon pushed a commit that referenced this issue Sep 10, 2020
* Update name validation for azurerm_storage_share_directory

* r/sorage_share_directory: support single char dirnames, properly detect leading/trailing dashes, allow double dashes

* Update code

* Update code

* Update code

Co-authored-by: Tom Bamford <[email protected]>
@ghost
Copy link

ghost commented Sep 10, 2020

This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.27.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants