azurerm_hdinsight_kafka_cluster: support rest proxy

[magodo]

This PR add supports for kafka rest proxy. To use kafka rest proxy, user will needs to specify both the rest prox setting and also a "kafka management node". In return, we will need to expose the endpoint for the kafka rest proxy.

Fixes #8053

[kosinsky]

Looks good for me.

[tombuildsstuff]

@magodo can you rebase this PR?

[magodo]

@tombuildsstuff I merged the master into this branch as that is easier to resolve the conflict.

[tombuildsstuff]

@patelprakashp respectfully, would you mind refraining from @-ing people asking when this’ll be merged?

Whilst I appreciate you’d like to see this feature merged, unfortunately each notification is more noise for maintainers, which ultimately means that things take longer to get reviewed since we have more noise to filter out - we instead ask that you use reactions (👍🏻) on the Issue/PR so that we can gauge interest. For the moment I’ve marked the “when will this be merged” comments as off-topic.

[tombuildsstuff]

hey @magodo

Thanks for this PR / rebasing this.

Taking a look through this is looking good - if we can fix up the comments here then we should be able to take another look 👍

Thanks!

[tombuildsstuff]

does this need to be conditionally set?

[magodo]

This should do no harm (and I refer to the same way which has been done for the EdgeNodeDef). Because when you do expand, it will further check whether user has specify the corresponding schema; when you do flatten, it will further find the corresponding property by name (in this case kafkamanagementnode) in the response body. In both cases, if the kafka management node is not enabled, it shall do nothing.

[magodo]

@tombuildsstuff

I have made the change that use aad client to get the group name instead of asking user to provide. Please take another look!

Test Result

💤 make testacc TEST=./azurerm/internal/services/hdinsight/tests TESTARGS='-run TestAccAzureRMHDInsightKafkaCluster_restProxy'
                                                                                                                                                              
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...                                                                                                        
TF_ACC=1 go test ./azurerm/internal/services/hdinsight/tests -v -run TestAccAzureRMHDInsightKafkaCluster_restProxy -timeout 180m -ldflags="-X=github.com/terra
form-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMHDInsightKafkaCluster_restProxy                                                                                                       
=== PAUSE TestAccAzureRMHDInsightKafkaCluster_restProxy                                                                                                       
=== CONT  TestAccAzureRMHDInsightKafkaCluster_restProxy
--- PASS: TestAccAzureRMHDInsightKafkaCluster_restProxy (1502.83s)                                                                                            
PASS   
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/hdinsight/tests     1502.859s

[katbyte]

@magodo - could we get this rebased? should be good to merge once thats done

[magodo]

@katbyte I've resolved the conflicts, please take another look!

💤 make testacc TEST=./azurerm/internal/services/hdinsight TESTARGS='-run "TestAccHDInsightKafkaCluster_restProxy|TestAccDataSourceHDInsightCluster_kafkaWithRestProxy"'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/hdinsight -v -run "TestAccHDInsightKafkaCluster_restProxy|TestAccDataSourceHDInsightCluster_kafkaWithRestProxy" -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceHDInsightCluster_kafkaWithRestProxy
=== PAUSE TestAccDataSourceHDInsightCluster_kafkaWithRestProxy
=== RUN   TestAccHDInsightKafkaCluster_restProxy
=== PAUSE TestAccHDInsightKafkaCluster_restProxy
=== CONT  TestAccDataSourceHDInsightCluster_kafkaWithRestProxy
=== CONT  TestAccHDInsightKafkaCluster_restProxy
--- PASS: TestAccDataSourceHDInsightCluster_kafkaWithRestProxy (1156.12s)
--- PASS: TestAccHDInsightKafkaCluster_restProxy (1168.85s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/hdinsight   1168.897s

[katbyte]

Thanks @magodo - this LGTM 👍

[ghost]

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!