Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HDInsight] KafkaRestProperties should not require groupName given groupId has been specified #10667

Closed
magodo opened this issue Sep 2, 2020 · 12 comments
Labels
HDInsight question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@magodo
Copy link
Contributor

magodo commented Sep 2, 2020

The ClientGroupInfo property already accept a groupId in request body, based on which service should be able to deduce the groupName. This issue suggest to remove the groupName from the model as an input property.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 2, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 7, 2020
@erich-wang erich-wang added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. Service Attention Workflow: This issue is responsible by Azure service team. labels Sep 7, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 7, 2020
@ghost
Copy link

ghost commented Sep 7, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @aim-for-better, @idear1203, @deshriva.

@aim-for-better
Copy link
Member

Hi @magodo , This is by design, This property not only as input but also as output. Please see here, This property will return to customer when they call Get cluster API.

@aim-for-better
Copy link
Member

Hi @magodo , This is by design, This property not only as input but also as output. Please see here, This property will return to customer when they call Get cluster API.

Returning group name is more readable for customer.

Could you please share more about this issue? For example, what's the impact on you?

@aim-for-better aim-for-better reopened this Sep 8, 2020
@magodo
Copy link
Contributor Author

magodo commented Sep 8, 2020

As the API consumer, it is more handy to provide the least amout of input in request. In this case, groupName can be deduced from groupId, which seems redundent to ask users to also specify. Otherwise, making groupName as output only (readOnly) might be a better choice here.

Specifically, I'm working on this feature in Terraform azurerm provider. Check out this comment: hashicorp/terraform-provider-azurerm#8064 (comment)

@deshriva
Copy link

@magodo : Thanks for the feedback. We have opened a work item and plan to address it in a future release.

@deshriva
Copy link

@magodo : Can we close this request, we have a work item and this change will be rolled out with a new API version.

@magodo
Copy link
Contributor Author

magodo commented Oct 26, 2020

@deshriva Thank you for the update, can we wait until the Swagger PR for that new API version is merged?

@aim-for-better
Copy link
Member

Thanks for the feedback. We have opened a work item and plan to address it in a future release.

@aim-for-better
Copy link
Member

on going

3 similar comments
@aim-for-better
Copy link
Member

on going

@aim-for-better
Copy link
Member

on going

@aim-for-better
Copy link
Member

on going

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HDInsight question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

5 participants