Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "deny public network access" in Azure Database for MySQL #6482

Closed
lcaille opened this issue Apr 15, 2020 · 8 comments
Closed

Support for "deny public network access" in Azure Database for MySQL #6482

lcaille opened this issue Apr 15, 2020 · 8 comments

Comments

@lcaille
Copy link

lcaille commented Apr 15, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When the Private Link is used, the MySql can be accessed using a private address. Therefore we should be able to deny public network access. This option should exists in azurerm_mysql_server

New or Affected Resource(s)

  • azurerm_mysql_server

Potential Terraform Configuration

resource "azurerm_mysql_server" "example" {

  ...

  public_network_access_enabled = true
}

References

@m2b-arariba
Copy link

This issue was fixed in v2.7.0

@rajatrawat99
Copy link

I was looking for the similar functionality for Azure sql but I was not able to find it. is "Deny public network access" is there for Azure sql? if not is there any plan to add it in future?

@katbyte
Copy link
Collaborator

katbyte commented Apr 26, 2020

@rajatrawat99 - so far we only support it in postgres and mysql. It should make its way to mssql & maria db in the next few weeks.

Closing as this was released in 2.7!

@katbyte katbyte closed this as completed Apr 26, 2020
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.8.0"
}
# ... other configuration ...

@kfyhn
Copy link

kfyhn commented May 1, 2020

Is it also on the roadmap for azurerm_sql_server?

@katbyte
Copy link
Collaborator

katbyte commented May 19, 2020

@kfyhn - this will not be added to azurerm_sql_server as it is using the older APIs which do not support that property. The replacement resource azurerm_mssql_server supports it but it seems like it didn't make it into the docs so i've opened #7011 to add that.

@rajatrawat99
Copy link

@katbyte so are you saying it wont be available for azurerm_sql_server and will be available for azurerm_mssql_server . Does it mean azurerm_mssql_server is advanced version of azurerm_sql_server and replacement for it? I am asking you as I can not see this on docs.

@ghost
Copy link

ghost commented May 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants