Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_bot_channel_ms_teams requires that calling_web_hook be set #5450

Closed
rukas opened this issue Jan 20, 2020 · 2 comments · Fixed by #7294
Closed

azurerm_bot_channel_ms_teams requires that calling_web_hook be set #5450

rukas opened this issue Jan 20, 2020 · 2 comments · Fixed by #7294

Comments

@rukas
Copy link
Contributor

rukas commented Jan 20, 2020

When attempting to create a new azurerm_bot_channel_ms_teams, enable_calling and calling_web_hook are supposed to both be optional. What I'm seeing is that the calling_web_hook setting needs to be set in order for this resource to be created.

I can work around this by specifying a dummy URL in calling_web_hook but this isn't the expected behavior. I've reviewed the release notes for this provider and don't see any fixes listed for this issue.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.12.13

  • provider.azuread v0.6.0
  • provider.azurerm v1.39.0
  • provider.random v2.2.1

Affected Resource(s)

  • azurerm_bot_channel_ms_teams

Terraform Configuration Files

resource "azuread_application" "test" {
  name                       = "test"
  available_to_other_tenants = true
  oauth2_allow_implicit_flow = false
}

resource "azurerm_bot_channels_registration" "test" {
  name                = "sometestname"
  display_name        = "Test"
  location            = "global"
  resource_group_name = "rg-name"
  sku                 = "S1"
  microsoft_app_id    = azuread_application.test.application_id
  endpoint            = "https://yourendpointhere.com"
}

resource "azurerm_bot_channel_ms_teams" "test" {
  bot_name            = "sometestname"
  location            = "global"
  resource_group_name = "rg-name"
}

Debug Output

Panic Output

Expected Behavior

Resource is created without specifying a calling_web_hook

Actual Behavior

Error: Error issuing create request for Channel MsTeams for Bot "rg-name" (Resource Group "rg-name"): botservice.ChannelsClient#Create: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="InvalidChannelData" Message="Invalid webhook: . 1.HTTPS URL 2.URL can't be localhost. 3. Can't be IP address."

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
njuCZ added a commit to njuCZ/terraform-provider-azurerm that referenced this issue Jun 11, 2020
@tombuildsstuff tombuildsstuff added this to the v2.14.0 milestone Jun 11, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.14.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants