adding oldest_create_index #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @flipyap! We're going to take a look at this soon! (Internal ref: https://hashicorp.atlassian.net/browse/NET-10944) |
tgross
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Hi @flipyap! I've left some minor comments but otherwise this looks great! Can you add a line to the CHANGELOG.md as well?
Once this ships, I'll follow-up with a docs PR here in the main Nomad repo.
Done! Thank you! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an "oldest_create_index" node selector to the list of selectors to help with behaviors similar to that of the default AWS scaling strategy.