Port the eslint config from UDR and next-hashicorp #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porting the linting setup from UDR was deemed to be easier and faster than attempting to modify `hashicorp-next`, republish and then try to integrate the new package version. The eslint config from UDR was written as an esmodule in order to use things like import - so a straight copy and paste wasn't possible. But with a little massaging (i.e: swapping out `import` for require) it seems to work in a rudimentary sense. Additionally, some tweaks had to be made to package.json to uninstall `hashicorp-next` and remove references to it in pre-commit hooks(in order to be able to commit) Finally the old rules from next-hashicorp were ported over in attempt to resolve lint issues and bring the lint rules in line with the current code style in devdot
rmainwork
requested review from
a team and
LeahMarieBush
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LeahMarieBush
approved these changes
Mar 5, 2025
eslint.config.js
Outdated
| '.next', | ||
| '**/dist', | ||
| 'eslint.config.js', | ||
| 'content', |
There was a problem hiding this comment.
dev-portal doesn't have a content directory so I think this can be removed
There was a problem hiding this comment.
Good point! I guess my rip was more shameless than I thought :p
There was a problem hiding this comment.
Fixed that in d3d638b
eslint.config.js
Outdated
| 'eslint.config.js', | ||
| 'content', | ||
| 'public', | ||
| 'vitest.config.mjs', |
There was a problem hiding this comment.
The vitest config file in dev-portal ends in mts instead of mjs
Devdot does not have a content directory, so there's no need to have it in the ignore list
The vitest config file has an extension of `.mts`, not `.mjs`
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Relevant links
🗒️ What
This PR is the first of several aimed to rectify the broken linting setup in devdot which has been the cause of at least one incident recently. The intent is to bring together multiple PRs (starting with this one) on to an assembly branch (
rm/fix-linting) and then PR from there intomain. This helps to reduce the size of each PR as well as getting multiple eyes and reviews on the changes being made.🤷 Why
This is an initial attempt to rectify the broken linting on dev dot by first bringing in the eslint config.
🛠️ How
Porting the linting setup from UDR was deemed to be easier and faster than attempting to modify
hashicorp-next, republish and then try to integrate the new package version.The eslint config from UDR was written as an esmodule in order to use things like import - so a straight copy and paste wasn't possible. But with a little massaging (i.e: swapping out
importfor require) it seems to work in a rudimentary sense.Additionally, some tweaks had to be made to package.json to uninstall
hashicorp-nextand remove references to it in pre-commit hooks(in order to be able to commit)Finally the old rules from next-hashicorp were ported over in attempt to resolve lint issues and bring the lint rules in line with the current code style in devdot