AdvancedTable: explicitly set select checkbox column width #2761
+38
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
reviewed
Mar 11, 2025
jorytindall
reviewed
Mar 11, 2025
| // if there is a select checkbox, the first column is 'auto' width to hug the checkbox content | ||
| let style = isSelectable ? 'auto' : ''; | ||
| // if there is a select checkbox, the first column is 'min-content' width to hug the checkbox content | ||
| let style = isSelectable ? 'min-content ' : ''; |
There was a problem hiding this comment.
Technically in Figma this is element is 48x48px, which referencing the showcase the dimensions are 49x48.
There was a problem hiding this comment.
@jorytindall does that include the border?
There was a problem hiding this comment.
@shleewhite good point, Figma doesn't visually represent the DOM in the same way, so no, that doesn't include the border; technically the border is "inside" of the element, which is a conceptual difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would fix an issue the explorer table had when converting to AdvancedTable. Basically, because every column in explorer has a set pixel width, if the user hides many columns then the checkbox column grows to fill the available space.
We also know that the select checkbox column is 50px wide since there is never any text and consumers cannot control the content of the cells in this column.
This PR also adds an example to the showcase that mimics the explorer use case.
📸 Screenshots
Before
After
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.