-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Layout::Grid
component implementation (HDS-4532)
#2756
Draft
KristinLBradley
wants to merge
7
commits into
flex-component-implementation
Choose a base branch
from
hds-4532-grid-component
base: flex-component-implementation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Layout::Grid
component implementation (HDS-4532)
#2756
KristinLBradley
wants to merge
7
commits into
flex-component-implementation
from
hds-4532-grid-component
+1,006
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Layout::Grid
component (HDS-4532)Layout::Grid
component implementation (HDS-4532)
2 tasks
8121f15
to
32ba2ae
Compare
…xed issue with inline flex layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STATUS: WIP (Implemented parent & child component, layout feature options, Showcase examples, & tests)
📌 Summary
If merged, this PR adds the
Layout::Gap
&Layout::Gap::Item
components to the design system.Showcase: https://hds-showcase-git-hds-4532-grid-component-hashicorp.vercel.app/layouts/grid
Related PR (for Layout::Flex): #2751
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.