Showcase - Add min-height to Shw::Label
#2746
Draft
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| .shw-label { | |||
| @include shw-font-family("rubik"); | |||
| min-height: 0.96rem; // needed to avoid vertical collapsing when the label is empty | |||
There was a problem hiding this comment.
Why so specific? (vs. a value like "1px" or something)
There was a problem hiding this comment.
I need to have the same (min) height as the other labels of the sibling items, to keep visual alignment.
|
I'm moving the PR to draft because there are too many failing visual regression tests in Percy, and I want to think a bit more about potential alternative solutions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Simple PR to add a
min-heightto theShw::Labelin the showcase, so it doesn't collapse when empty.👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.