Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): exclude app-header components #2733

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −13
Open

feat(components): exclude app-header components #2733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions packages/components/rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,22 @@ const addon = new Addon({
destDir: 'dist',
});

const exclude = ['components/hds/app-header', 'components/hds/app-side-nav'];

const plugins = [
// These are the modules that users should be able to import from your
// addon. Anything not listed here may get optimized away.
addon.publicEntrypoints([
'**/*.{js,ts}',
'index.js',
'template-registry.js',
'styles/@hashicorp/design-system-components.scss',
]),
addon.publicEntrypoints(
[
'**/*.{js,ts}',
'index.js',
'template-registry.js',
'styles/@hashicorp/design-system-components.scss',
],
{
exclude,
}
),

// These are the modules that should get reexported into the traditional
// "app" tree. Things in here should also be in publicEntrypoints above, but
Expand All @@ -36,10 +43,7 @@ const plugins = [
'instance-initializers/**/*.js',
],
{
exclude: [
'components/**/app-header/**/*.js',
'components/**/app-side-nav/**/*.js',
],
exclude,
}
),

Expand Down
6 changes: 3 additions & 3 deletions packages/components/src/components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ export { default as HdsAppFooterStatusLink } from './components/hds/app-footer/s
export * from './components/hds/app-footer/types.ts';

// AppHeader
export { default as HdsAppHeader } from './components/hds/app-header/index.ts';
export { default as HdsAppHeaderHomeLink } from './components/hds/app-header/home-link.ts';
export { default as HdsAppHeaderMenuButton } from './components/hds/app-header/menu-button.ts';
// export { default as HdsAppHeader } from './components/hds/app-header/index.ts';
// export { default as HdsAppHeaderHomeLink } from './components/hds/app-header/home-link.ts';
// export { default as HdsAppHeaderMenuButton } from './components/hds/app-header/menu-button.ts';

// ApplicationState
export { default as HdsApplicationState } from './components/hds/application-state/index.ts';
Expand Down
Loading