Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting support for hds-code-editor modifier and component #2715

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Linting support for hds-code-editor modifier and component #2715

wants to merge 32 commits into from

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Feb 19, 2025 •
edited by jira bot
Loading

📌 Summary

If merged, this PR will add support for linting to the hds-code-editor modifier and Hds::CodeEditor component.

🛠️ Detailed description

  • Linting is currently available only for the JSON language.
  • Linting can be enabled by setting language to json & isLintingEnabled to true.
  • The editor accepts a new onLint argument which accepts a function that is called when linting runs and receives an array of CodeMirror Diagnostic objects.

📸 Screenshots

Screenshot 2025-03-07 at 2 51 00 PM

🔗 External links

Jira ticket: HDS-4361
Figma file: [if it applies]

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@vercel Vercel
Copy link

vercel bot commented Feb 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Mar 7, 2025 7:56pm
hds-website ✅ Ready (Inspect) Visit Preview Mar 7, 2025 7:56pm

@zamoore zamoore force-pushed the zamoore/HDS-4361/CodeEditor-linting branch from 3aa5ce6 to cea554c Compare February 21, 2025 22:12
zamoore added 26 commits March 7, 2025 14:52
@zamoore
linting logic is in
ed40607
@zamoore
the linting drawer opens with the key command now
109dd43
@zamoore
working on lint tooltip styling
ac8e2f9
@zamoore
working on styline the linting elements
cac1220
@zamoore
updating tooltip styles
b37396d
@zamoore
updating styles for linting drawer
48e8e5c
@zamoore
working on styles for the panel close button
1ea24e7
@zamoore
drawer diagnostic finished styling
8d8bb3f
@zamoore
styling the selected panel
4e1797f
@zamoore
finalized code editor UI
ef669fd
@zamoore
enable the minimum height of the editor only if linting is enabled
a9700c8
@zamoore
increased close button size
4850a0d
@zamoore
added unit tests for linting methods
e0fdfe0
@zamoore
working on documentation
85288c5
@zamoore
updating docs
0d8d0f2
@zamoore
responding to design feedback
93fa537
@zamoore
revert changest to website
e7c49d4
@zamoore
added missing dependency to showcase for tests
a318460
@zamoore
fixing test
f29fa8a
@zamoore
pr cleanup
750607f
@zamoore
cleaning up types and imports
280e66c
@zamoore
cleaned up PR
406fdbd
@zamoore
added changeset
f7306b8
@zamoore
cleaned up PR
4902f8f
@zamoore
fixed linting drawer display issue
ecb1f99
@zamoore
fixing border colors
02e764e
@zamoore zamoore force-pushed the zamoore/HDS-4361/CodeEditor-linting branch from c192a50 to 02e764e Compare March 7, 2025 19:52
@zamoore zamoore requested a review from a team March 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages/components showcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zamoore @hashibot-hds @alex-ju