feat: enable embroider-optimized scenario
#2703
Draft
+787
−422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aklkv
force-pushed
the
feat/embroider-optimized
branch
from
995f3d0 to
04fd45a
Compare
aklkv
force-pushed
the
feat/embroider-optimized
branch
from
04fd45a to
1cddde5
Compare
aklkv
force-pushed
the
feat/embroider-optimized
branch
from
1cddde5 to
85be444
Compare
aklkv
force-pushed
the
feat/embroider-optimized
branch
from
85be444 to
fc638c7
Compare
aklkv
force-pushed
the
feat/embroider-optimized
branch
from
fc638c7 to
6a84391
Compare
aklkv
force-pushed
the
feat/embroider-optimized
branch
from
6a84391 to
6116f26
Compare
aklkv
force-pushed
the
feat/embroider-optimized
branch
from
6116f26 to
fb1fe26
Compare
aklkv
force-pushed
the
feat/embroider-optimized
branch
from
fb1fe26 to
2adcf1d
Compare
aklkv
force-pushed
the
feat/embroider-optimized
branch
from
2adcf1d to
ade570e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Enable
embroider-optimizedand removeallowedToFailflag, this is ultimate goal of this whole project and will take a lot longer to figure out, I do not expect it to be merged fast (this allows consumers to actually run embroider/webpack and vite withstaticInvokablesturned on🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-3123
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.