This repository was archived by the owner on Aug 25, 2021. It is now read-only.
server-acl-init: Support connecting to external servers with an SNI header #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
added
bug
ishustava
requested review from
a team,
lkysow and
sadjamz
and removed request for
a team
lkysow
approved these changes
Jun 28, 2021
sadjamz
approved these changes
Jun 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Currently, when running with consul servers outside the k8s clusters and using ACLs, the server-acl-init job will expect the server's host to be included in the server's certificate. However, if you're connecting to the server over pod or node IPs, that IP will not be included in the certificate. These use cases are typically solved by providing an SNI header when connecting to the server (
externalServers.tlsServerNamein this case), however, we were not setting this property as a flag for the server-acl-init command.How I've tested this PR:
Manually by deploying external servers on another k8s cluster and using a flat pod and node networks.
How I expect reviewers to test this PR:
code review
Checklist: