Fix locationType deprecations. #2721
Open
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before setting configuration
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thank you for cleaning this up, great catch!!
this doesn't really affect anything but we should probably still clean-up this 'auto' usage too
lisbet-alvarez
previously approved these changes
Mar 11, 2025
Great catch!! Not that I am looking to put effort in rose, since we know eventually we want to deprecate it, but this one I agree with you takes no time to fix it, so I pushed the change! thanks for the catch @lisbet-alvarez |
DhariniJeeva
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Within Desktop Client, we never deprecated auto location, more info about this deprecation here. Therefore, when running the DC in the browser we were seeing 2 deprecations messages:
autoas value has been deprecated. So onlyhashorhistoryare accepted.locationTypesetting.To solve 1, we decide to change
autoto usehistory. As per documentation,autowill useshistoryif supported by the browsers and fallback tohashif not. Since we are pretty sure the browser used by electron supportshistory, is safe to directly useshistory.To solve 2, we decide to set a const with the value before we are setting the environment config, therefore at setting time the variable has already a value.
Screenshots:
Before, showing deprecation messages:
After, showing no deprecation messages
